clintropolis commented on a change in pull request #8834: Fixes, adjustments to
numeric null handling and string first/last aggregators.
URL: https://github.com/apache/incubator-druid/pull/8834#discussion_r343937478
##########
File path:
extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/BloomFilterAggregatorFactory.java
##########
@@ -279,16 +280,21 @@ private BaseBloomFilterAggregator
factorizeInternal(ColumnSelectorFactory column
);
}
} else {
+ // No column capabilities, try to guess based on selector type.
BaseNullableColumnValueSelector selector =
columnFactory.makeColumnValueSelector(field.getDimension());
+
if (selector instanceof NilColumnValueSelector) {
return new NoopBloomFilterAggregator(maxNumEntries, onHeap);
+ } else if (selector instanceof DimensionSelector) {
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
