ccaominh commented on a change in pull request #8823: Add InputSource and
InputFormat interfaces
URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343942960
##########
File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java
##########
@@ -306,6 +306,33 @@ public void close()
}
}
+ public static long copyLarge(
Review comment:
Since this is almost the same as the method above, it'd be good to factor
out the common parts to a private helper method. Also, since it's a library
function used in several places, it would be good to add a unit test to
`FileUtilsTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
