clintropolis commented on issue #8822: optimize numeric column null value 
checking for low filter selectivity (more rows)
URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-551458539
 
 
   I repeated the benchmarks after being modified to have the latest changes to 
make sure everything was still good, this time on an AWS `m5.large`, and they 
appear to be approximately the same with the peekable iterator faring ever so 
slightly better than last time around:
   
   ##### peekable iterator better than get:
   
   
![per-row-peekable-iterator-better](https://user-images.githubusercontent.com/1577461/68465704-d44a9a00-01c7-11ea-8058-5d87c662f688.gif)
   
   
   ##### get better than peekable iterator:
   
![per-row-peekable-iterator-get-better](https://user-images.githubusercontent.com/1577461/68465403-453d8200-01c7-11ea-893c-ecffc36b868a.gif)
   
   
   
[get-vs-iterator-vs-peekable-redux.csv.zip](https://github.com/apache/incubator-druid/files/3823860/get-vs-iterator-vs-peekable-redux.csv.zip)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to