fjy commented on a change in pull request #8841: add readiness endpoints to
processes having initialization delays
URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344274695
##########
File path:
services/src/main/java/org/apache/druid/cli/QueryJettyServerInitializer.java
##########
@@ -45,16 +46,20 @@
import org.eclipse.jetty.servlet.ServletContextHandler;
import org.eclipse.jetty.servlet.ServletHolder;
-import java.util.Collections;
import java.util.List;
import java.util.Set;
/**
+ *
*/
public class QueryJettyServerInitializer implements JettyServerInitializer
{
private static final Logger log = new
Logger(QueryJettyServerInitializer.class);
- private static List<String> UNSECURED_PATHS =
Collections.singletonList("/status/health");
+ private static List<String> UNSECURED_PATHS = Lists.newArrayList(
+ "/status/health",
+ "/druid/historical/v1/readiness",
Review comment:
I think we should use a consistent scheme here. I'd prefer just /status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
