jihoonson commented on a change in pull request #8810: Make submit task API 
similar to supervisor API
URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344393304
 
 

 ##########
 File path: 
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskParallelRunTest.java
 ##########
 @@ -197,6 +197,9 @@ private void runIndexTask() throws Exception
             false
         ),
         null,
+        null,
 
 Review comment:
   Please add another constructor to `IndexTask` which is compatible to the old 
constructor so that you can minimize the change of this PR. The constructor 
should be `@VisibleForTesting` and `@Deprecated`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to