clintropolis commented on issue #8838: Web console: replace (and remove) old 
consoles
URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-552145722
 
 
   >What is the deal here? What does the notice: key represent and should 
script/licenses be updated to generate it?
   
   The notice sections are _manually_ maintained, and in fact must be, because 
we don't automatically include the entire notice, rather the part that is 
relevant to the code being used by Druid. These parts generate Druids own 
source and binary `NOTICE` files at distribution build time, so are really 
important to be correct and maintained. 
   
   I think we  should probably modify the script to indicate to whoever runs it 
whenever a version of a dependency is updated that had a `notice` entry so that 
it can be manually updated. We went through all of the web dependencies as part 
of previous releases, but whenever we add new dependencies we should ensure 
that if they have a `NOTICE` file that the relevant contents make it into 
`licenses.yaml`. I don't think this script modification needs to be done as 
part of this PR, but we should at least preserve (and probably update) the 
notice entry for tslib.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to