jihoonson commented on a change in pull request #8823: Add InputSource and
InputFormat interfaces
URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346630087
##########
File path:
core/src/main/java/org/apache/druid/data/input/InputRowListPlusJson.java
##########
@@ -62,23 +95,19 @@ public InputRow getInputRow()
}
@Nullable
- public ParseException getParseException()
- {
- return parseException;
- }
-
- public boolean isEmpty()
+ public String getRawJson()
{
- return inputRow == null && raw == null && parseException == null;
+ return rawJson;
}
- public static InputRowPlusRaw of(@Nullable InputRow inputRow, @Nullable
byte[] raw)
+ @Nullable
+ public ParseException getParseException()
{
- return new InputRowPlusRaw(inputRow, raw, null);
+ return parseException;
}
- public static InputRowPlusRaw of(@Nullable byte[] raw, @Nullable
ParseException parseException)
+ public boolean isEmpty()
{
- return new InputRowPlusRaw(null, raw, parseException);
+ return (inputRows == null || inputRows.isEmpty()) && raw == null &&
rawJson == null && parseException == null;
Review comment:
This class is also used only by sampler and will be cleaned up in the
follow-up pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
