suneet-amp commented on issue #8909: Optimize CachingLocalSegmentAllocator#getSequenceName URL: https://github.com/apache/incubator-druid/pull/8909#issuecomment-555729329 > Would you fix the style issue? > > ``` > [ERROR] /home/travis/build/apache/incubator-druid/indexing-service/src/main/java/org/apache/druid/indexing/common/task/CachingLocalSegmentAllocator.java:30:8: Unused import - org.apache.druid.java.util.common.StringUtils. [UnusedImports] > ``` > > Also, would you mind adding a comment why it's not using `StringUtils.format()`? Will do! Chi's comment about toString() generating the correct format had me a little worried so I'm adding a simple unit test. Fighting with the styling guidelines right now. Should have another patch out within a day
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
