jihoonson commented on a change in pull request #8779: Handle missing values
for delimited text files when Nullhandling is enabled
URL: https://github.com/apache/incubator-druid/pull/8779#discussion_r348219543
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/overlord/sampler/FirehoseSamplerTest.java
##########
@@ -814,9 +814,7 @@ private ParseSpec getParseSpec(TimestampSpec
timestampSpec, DimensionsSpec dimen
private String getUnparseableTimestampString()
{
return ParserType.STR_CSV.equals(parserType)
- ? (USE_DEFAULT_VALUE_FOR_NULL
- ? "Unparseable timestamp found! Event: {t=bad_timestamp,
dim1=foo, dim2=null, met1=6}"
- : "Unparseable timestamp found! Event: {t=bad_timestamp,
dim1=foo, dim2=, met1=6}")
+ ? "Unparseable timestamp found! Event: {t=bad_timestamp, dim1=foo,
dim2=null, met1=6}"
Review comment:
I think this should be ok. @nishantmonu51 do you have something in your mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
