clintropolis commented on a change in pull request #8779: Handle missing values
for delimited text files when Nullhandling is enabled
URL: https://github.com/apache/incubator-druid/pull/8779#discussion_r348311004
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/parsers/CSVParser.java
##########
@@ -29,7 +32,10 @@
public class CSVParser extends AbstractFlatTextFormatParser
{
- private final RFC4180Parser parser = new RFC4180Parser();
+ private final RFC4180Parser parser = NullHandling.replaceWithDefault()
+ ? new RFC4180Parser()
+ : new
RFC4180ParserBuilder().withFieldAsNull(
Review comment:
I wonder if this could just be the all the time mode, since _I think_ it
wouldn't really change anything for the default mode either since the values
would be coerced to ''.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
