jihoonson commented on a change in pull request #8566: Upgrade Calcite to 1.21 URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r348724331
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerContext.java ########## @@ -49,6 +49,7 @@ public static final String CTX_SQL_QUERY_ID = "sqlQueryId"; public static final String CTX_SQL_CURRENT_TIMESTAMP = "sqlCurrentTimestamp"; public static final String CTX_SQL_TIME_ZONE = "sqlTimeZone"; + public static final String CTX_SQL_OUTER_LIMIT = "sqlOuterLimit"; Review comment: I think it would be better to document internal parameters somewhere rather than depending on human memory. But I think we can do in a follow-up pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
