leventov commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r348945394
##########
File path:
extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisor.java
##########
@@ -67,13 +66,13 @@
public class MaterializedViewSupervisor implements Supervisor
{
private static final EmittingLogger log = new
EmittingLogger(MaterializedViewSupervisor.class);
- private static final Interval ALL_INTERVAL =
Intervals.of("0000-01-01/3000-01-01");
private static final int DEFAULT_MAX_TASK_COUNT = 1;
// there is a lag between derivatives and base dataSource, to prevent
repeatedly building for some delay data.
- private static final long DEFAULT_MIN_DATA_LAG_MS = 24 * 3600 * 1000L;
+ private static final long DEFAULT_MIN_DATA_LAG_MS =
TimeUnit.DAYS.toMillis(1);
+
private final MetadataSupervisorManager metadataSupervisorManager;
private final IndexerMetadataStorageCoordinator metadataStorageCoordinator;
- private final SQLMetadataSegmentManager segmentManager;
+ private final SqlSegmentsMetadata sqlSegmentsMetadata;
Review comment:
I don't feel so. It's just a noun phrase - it doesn't imply read-only
access. Like `ArrayList` is just a noun phrase and it doesn't imply read-only
access.
I believe "Manager" adds zero meaning to this class's name and it was one of
the objectives of the PR to shorten these too long class names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
