clintropolis opened a new pull request #8919: fix bug with sqlOuterLimit, use sqlOuterLimit in web console URL: https://github.com/apache/incubator-druid/pull/8919 ### Description This PR modifies the 'smart limit' strategy in the web-console query view to use the `sqlOuterLimit` parameter introduced in #8566. It also fixes a bug with `sqlOuterLimit` if the outer rel is already a `LogicalSort` which would cause a query which should plan to a topN but without a limit set to be unplannable. The logic now will modify the limit of an outer sort instead of wrapping it in another sort. <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [x] been tested in a test Druid cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
