ccaominh commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r349756060
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentPuller.java
##########
@@ -84,7 +81,7 @@ public S3DataSegmentPuller(ServerSideEncryptingAmazonS3
s3Client)
try {
org.apache.commons.io.FileUtils.forceMkdir(outDir);
- final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.bucket, s3Coords.path));
+ final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.getBucket(), s3Coords.getPath()));
Review comment:
Is the problem that described in
https://github.com/apache/incubator-druid/pull/8903/files/a4f6ae9ae2f81381d865e87ec5e1219d275f299c..7125e3e94bd468bc82c95fad68538890a23c69ee#r348869424
possible here when the `URI` created here gets passed to the
`CloudObjectLocation` constructor?
Is there a test to check the handling of tricky characters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
