jihoonson commented on a change in pull request #8925: Parallel indexing single
dim partitions
URL: https://github.com/apache/incubator-druid/pull/8925#discussion_r349818125
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -519,6 +574,101 @@ private TaskStatus
runHashPartitionMultiPhaseParallel(TaskToolbox toolbox) throw
return TaskStatus.fromCode(getId(), state);
}
+ private TaskStatus runRangePartitionMultiPhaseParallel(TaskToolbox toolbox)
throws Exception
+ {
+ assertDataSketchesAvailable();
Review comment:
This method will be called after the task is assigned to a middleManager or
an indexer which could be resource and time wasting if the datasketch extension
is not loaded. I think it's not common to load datasketch in middleManagers but
not in the overlord. Can we check this in `isReady()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
