clintropolis commented on a change in pull request #8870: Additional Kinesis
resharding fixes
URL: https://github.com/apache/incubator-druid/pull/8870#discussion_r351531668
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -2285,7 +2385,9 @@ private void checkTaskDuration() throws
ExecutionException, InterruptedException
}
// clear partitionGroups, so that latest sequences from db is used as
start sequences not the stale ones
// if tasks did some successful incremental handoffs
- partitionGroups.get(groupId).replaceAll((partition, sequence) ->
getNotSetMarker());
+ for (PartitionIdType partitionId : group.startingSequences.keySet()) {
Review comment:
nit: I see this loop repeated a few times, maybe good to make a method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
