jon-wei commented on a change in pull request #8962: Exclude unneeded hadoop 
transitive dependencies
URL: https://github.com/apache/incubator-druid/pull/8962#discussion_r351549325
 
 

 ##########
 File path: services/src/main/java/org/apache/druid/cli/PullDependencies.java
 ##########
 @@ -141,12 +142,24 @@
       "org.roaringbitmap",
       "net.java.dev.jets3t"
       */
-  );
 
   private static final List<String> DEFAULT_REMOTE_REPOSITORIES = 
ImmutableList.of(
       "https://repo1.maven.org/maven2/";
   );
 
+  // These are either not needed or are provided by core
+  private static final Exclusions 
HADOOP_DEFAULT_SECURITY_VULNERABILITY_EXCLUSIONS =
 
 Review comment:
   Can we split this to have one set of security exclusions and another set for 
provided-by-core exclusions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to