jon-wei opened a new pull request #8982: Add DruidInputSource (replacement for 
IngestSegmentFirehose)
URL: https://github.com/apache/incubator-druid/pull/8982
 
 
   Based on an initial patch by @jihoonson 
   
   This PR adds `DruidInputSource` and associated classes, a new replacement 
for `IngestSegmentFirehose`. This input source always has a fixed input format 
(`DruidInputFormat`). The row reading class is `DruidSegmentReader` and the 
input entity is `DruidInputEntity`.
   
   The new input source has the same parameters as the existing 
IngestSegmentFirehose.
   
   Additionally:
   - The PR adjusts the CompactionTask so that it uses DruidInputSource instead 
of the old firehose.
   - Fixes an issue where the value of `inputSource.needsFormat()` was not 
being respected.
   - The new input source avoids the issue described in #8448, which is present 
in the old firehose
   
   For testing, this patch relies on the existing CompactionTask tests for 
checking functionality of the new input source. 
   
   A test where an IngestSegmentFirehose is used for reindexing with a native 
batch task (non-parallel) has also been added to `CompactionRunTaskTest`. The 
existing `ITParallelIndexTaskTest` still uses a firehose instead of input 
source.
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to