qutang1 commented on a change in pull request #8974: Fix double-checked locking
in predicate suppliers in BoundDimFilter
URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r353538688
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/BoundDimFilter.java
##########
@@ -361,107 +361,107 @@ public String toString()
class BoundLongPredicateSupplier implements Supplier<DruidLongPredicate>
Review comment:
> In this case, it's better to turn off auto-formatting in your IDE and
accurately revert unrelated changes.
>
> For a longer-term solution, if you plan to contribution to the project
regularly, it's better to consult developers at
[d...@druid.apache.org](mailto:d...@druid.apache.org)
In the line 58 of eclipse_formatting.xml, it should be changed to:
<setting
id="org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement"
value="insert"/> instead of "do not insert". By making this change, "catch"
block will be alone on a line to in line with CI standard. Thus eclipse
auto-formatting will be correct. I think the xml should be updated although I
guess no one else than me is still using eclipse...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
