himanshug commented on a change in pull request #8697: HRTR: make pending task
execution handling to go through all tasks on not finding worker slots
URL: https://github.com/apache/incubator-druid/pull/8697#discussion_r357343567
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java
##########
@@ -1138,6 +1139,12 @@ private void pendingTasksExecutionLoop()
// set state to PENDING_WORKER_ASSIGN before releasing the lock so
that this task item is not picked
// up by another task execution thread.
+ // note that we can't simply delete this task item from
pendingTaskIds or else we would have to add it
+ // back if this thread couldn't run this task for any reason,
which we will know at some later time
+ // and also we will need to add it back to its old position in the
list. that becomes complex quickly.
+ // Instead we keep the PENDING_WORKER_ASSIGN to notify other task
execution threads not to pick this one up.
+ // And, it is automatically removed by any of the task exeuction
threads when they notice that
Review comment:
fixed, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
