jon-wei edited a comment on issue #9154: Fix LongSumAggregator comparator null handling URL: https://github.com/apache/druid/pull/9154#issuecomment-572342662 @clintropolis @jihoonson Pushed a new update with the following: - As the sample data has been updated with new columns, this PR also updates other query-related tests with the NullHandling initialization and other test adjustments. - Updates SearchQueryRunner to call `selector.isNull()` in its numeric column selectors since the search query tests were failing on the new sample data columns - Refactors ScanQueryRunnerTest so that it reads its sample data from the common resource TSV file instead of replicating the data within the test for its main test data (some tests still use test-specific data)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
