jnaous commented on issue #8728: Initial join support
URL: https://github.com/apache/druid/issues/8728#issuecomment-573050806
 
 
   - Awesome sauce!
   - I think what's missing here as well is a bit of discussion on the 
ingestion side of dimension tables.
   - You mention "master datasource" under Broker Behavior. First time it's 
mentioned in this doc. With no prior explanation. Do you mean the base 
datasource?
   - Under Test Plan it would be good to see some more comprehensive sets of 
queries that you expect to be supported and others that won't be, ideally in 
order of complexity. Perhaps we can use that to stage implementation phases by 
scoping them to supported query types?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to