jnaous commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365292780
##########
File path:
processing/src/main/java/org/apache/druid/segment/QueryableIndexStorageAdapter.java
##########
@@ -103,7 +98,8 @@ public int getDimensionCardinality(String dimension)
{
ColumnHolder columnHolder = index.getColumnHolder(dimension);
if (columnHolder == null) {
- return 0;
+ // NullDimensionSelector has cardinality = 1 (one null, nothing else).
+ return 1;
Review comment:
I'm curious about the impact of this small change...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
