jihoonson commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r367161564
##########
File path:
processing/src/main/java/org/apache/druid/segment/VectorColumnProcessorFactory.java
##########
@@ -17,25 +17,32 @@
* under the License.
*/
-package org.apache.druid.query.dimension;
+package org.apache.druid.segment;
import org.apache.druid.segment.vector.MultiValueDimensionVectorSelector;
import org.apache.druid.segment.vector.SingleValueDimensionVectorSelector;
import org.apache.druid.segment.vector.VectorValueSelector;
/**
* Class that encapsulates knowledge about how to create vector column
processors. Used by
- * {@link org.apache.druid.segment.DimensionHandlerUtils#makeVectorProcessor}.
+ * {@link DimensionHandlerUtils#makeVectorProcessor}.
+ *
+ * Unlike {@link ColumnProcessorFactory}, this interface does not have a
"defaultType" method. The default type is
+ * always implicitly STRING. It also does not have a "makeComplexProcessor"
method; instead, complex-typed columns
Review comment:
Would you elaborate more on why the default type is always string? Or is it
a temporary thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
