leventov commented on a change in pull request #9179: Run IntelliJ inspections
on Travis
URL: https://github.com/apache/druid/pull/9179#discussion_r367282750
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/ColumnarLongs.java
##########
@@ -121,14 +122,14 @@ public boolean isNull()
@Override
public long getLong()
{
- assert NullHandling.replaceWithDefault() || !isNull();
+ Preconditions.checkState(NullHandling.replaceWithDefault() ||
!isNull());
Review comment:
Why this change?
The policy regarding asserts, project-wide should be discussed in the dev
mailing list, probably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
