leventov commented on issue #9134: Fix concurrency of ComplexMetrics.java URL: https://github.com/apache/druid/pull/9134#issuecomment-575548942 Updated https://github.com/code-review-checklists/java-concurrency#multi-threaded-tests. Answering the question "What is the worst thing that might happen if this code has a concurrency bug?" which I proposed there, I think in case of the former version of ComplexMetrics, it would be a runtime exception while registering or getting a Serde, which may result in a single Druid query failing with error, or an indexing job failing to write data, or a node failing to start up, all with clear exception stack traces. These consequences are relatively benign: could be fixed with node restart or by themselves, no permanent data corruption.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
