swapneshgandhi commented on a change in pull request #8272: Support incremental
load in Druid lookups
URL: https://github.com/apache/druid/pull/8272#discussion_r369191774
##########
File path:
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
##########
@@ -197,14 +200,28 @@ public void run()
}
}
- public VersionedCache createFromExistingCache(
+ /**
+ *
+ *
+ * @param entryId an object uniquely corresponding to the {@link
CacheScheduler.Entry},
+ * to create Cache from
+ * @param version version, associated with the cache
+ * @param pairs List of Pairs consisting of new cache entries to be added
to current Cache.
+ * @return a new {@link VersionedCache} by adding pairs to existing cache,
This operation is
+ * non atomic and for Off-Heap caches there's possibility this will lead
to a crash, in case
+ * of use-after-free.
+ */
+ public @Nullable VersionedCache createFromExistingCache(
@Nullable EntryImpl<? extends ExtractionNamespace> entryId,
String version,
- Map<String, String> newCacheEntries
+ List<Pair<String, String>> pairs
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
