vogievetsky commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369987327
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -149,15 +149,15 @@ export interface DatasourcesViewState {
datasourcesError?: string;
datasourceFilter: Filter[];
- showDisabled: boolean;
+ showUnused: boolean;
retentionDialogOpenOn?: RetentionDialogOpenOn;
compactionDialogOpenOn?: CompactionDialogOpenOn;
- dropDataDatasource?: string;
- enableDatasource?: string;
+ dataSourceToMarkAsUnusedAllSegmentsIn?: string;
+ dataSourceToMarkAllNonOvershadowedSegmentsAsUsedIn?: string;
killDatasource?: string;
- dropReloadDatasource?: string;
- dropReloadAction: 'drop' | 'reload';
- dropReloadInterval: string;
+ dataSourceToMarkSegmentsByIntervalIn?: string;
Review comment:
This is a great rename, it is good to have the UI aligned with the docs.
Could you please make sure that we treat "datasource" as one word I have been
consistently using "datasource" for the Druid table thing and "data source" for
the source of data like S3 or HDFS (in the data loader).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
