leventov commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r370271813
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -346,104 +348,103 @@ GROUP BY 1`;
this.datasourceQueryManager.terminate();
}
- renderDropDataAction() {
- const { dropDataDatasource } = this.state;
- if (!dropDataDatasource) return;
+ renderUnuseAction() {
+ const { dataSourceToMarkAsUnusedAllSegmentsIn } = this.state;
+ if (!dataSourceToMarkAsUnusedAllSegmentsIn) return;
return (
<AsyncActionDialog
action={async () => {
const resp = await axios.delete(
- `/druid/coordinator/v1/datasources/${dropDataDatasource}`,
+
`/druid/coordinator/v1/datasources/${dataSourceToMarkAsUnusedAllSegmentsIn}`,
{},
);
return resp.data;
}}
- confirmButtonText="Drop data"
- successText="Data drop request acknowledged, next time the coordinator
runs data will be dropped"
- failText="Could not drop data"
+ confirmButtonText="Mark as unused all segments in data source"
Review comment:
I shortened confirm button texts but just removed "in data source" parts,
IMO even shorter names are too ambiguous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
