clintropolis commented on a change in pull request #6974: sql support for
dynamic parameters
URL: https://github.com/apache/druid/pull/6974#discussion_r370594506
##########
File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidStatement.java
##########
@@ -152,27 +162,36 @@ public DruidStatement prepare(
try {
ensure(State.NEW);
sqlLifecycle.initialize(query, queryContext);
- sqlLifecycle.planAndAuthorize(authenticationResult);
+
+ this.authenticationResult = authenticationResult;
+ PrepareResult prepareResult =
sqlLifecycle.prepare(authenticationResult);
this.maxRowCount = maxRowCount;
this.query = query;
+ ArrayList<AvaticaParameter> params = new ArrayList<>();
Review comment:
Moved the construction of the parameters that go in the list, which is close
to the suggested refactor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
