gianm commented on a change in pull request #9251: fix some issues with filters
on numeric columns with nulls
URL: https://github.com/apache/druid/pull/9251#discussion_r371536631
##########
File path:
processing/src/main/java/org/apache/druid/segment/vector/VectorSelectorUtils.java
##########
@@ -57,7 +57,8 @@
final int row = i + startOffset;
nullIterator.advanceIfNeeded(row);
if (!nullIterator.hasNext()) {
- break;
Review comment:
How about using `Arrays.fill` to fill the rest with falses, and then break?
Should be somewhat more efficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
