jihoonson commented on a change in pull request #9265: Improve code quality and
unit test coverage of the Azure extension
URL: https://github.com/apache/druid/pull/9265#discussion_r373217634
##########
File path:
extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java
##########
@@ -157,6 +128,7 @@ public DataSegment push(final File indexFilesDir, final
DataSegment segment, fin
);
}
catch (Exception e) {
+ // do we want to throw a specfic exception here? Interface only expects
IOExceptions to be thrown.
Review comment:
Haha, is this question for the reviewers? I think `RuntimeException` is
enough for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
