clintropolis commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests. URL: https://github.com/apache/druid/pull/9310#discussion_r375064517
########## File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java ########## @@ -129,20 +133,24 @@ import org.apache.druid.sql.calcite.view.ViewManager; import org.apache.druid.timeline.DataSegment; import org.apache.druid.timeline.partition.LinearShardSpec; -import org.easymock.EasyMock; Review comment: To do the former i would also need to implement `FakeDruidNodeDiscovery` too I think for the provider to provide to get the list of servers.. which i guess isn't that big a deal probably... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
