suneet-s commented on a change in pull request #9319: Make Transform an 
ExtensionPoint
URL: https://github.com/apache/druid/pull/9319#discussion_r375671116
 
 

 ##########
 File path: docs/development/modules.md
 ##########
 @@ -46,6 +46,7 @@ Druid's extensions leverage Guice in order to add things at 
runtime.  Basically,
 1. Add new Jersey resources by calling `Jerseys.addResource(binder, clazz)`.
 1. Add new Jetty filters by extending 
`org.apache.druid.server.initialization.jetty.ServletFilterHolder`.
 1. Add new secret providers by extending 
`org.apache.druid.metadata.PasswordProvider`.
+1. Add new ingest transform by implementing the 
`org.apache.druid.segment.transform.Transform` interface from the 
`druid-processing` package.
 
 Review comment:
   Can you add a section in here describing how to register the custom 
transformation similar to what's documented for adding support for an Input 
Source 
(https://github.com/apache/druid/blob/118e89c1e2ae9ea0e1c923c355bff6f1ccacf756/docs/development/modules.md#adding-support-for-a-new-input-source)
 or a Password Provider 
(https://github.com/apache/druid/blob/118e89c1e2ae9ea0e1c923c355bff6f1ccacf756/docs/development/modules.md#adding-a-new-password-provider-implementation)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to