jihoonson commented on a change in pull request #9076: variance aggregator
support for double columns
URL: https://github.com/apache/druid/pull/9076#discussion_r378021144
##########
File path:
extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/sql/BaseVarianceSqlAggregator.java
##########
@@ -102,7 +102,9 @@ public Aggregation toDruidAggregation(
if (inputType == ValueType.LONG) {
inputTypeName = "long";
- } else if (inputType == ValueType.FLOAT || inputType == ValueType.DOUBLE) {
+ } else if (inputType == ValueType.DOUBLE) {
Review comment:
nit: can be
```java
switch (inputType) {
case LONG:
case FLOAT:
case DOUBLE:
inputTypeName = StringUtils.toLowerCase(inputType.name());
break;
default:
throw new IAE("VarianceSqlAggregator[%s] has invalid inputType[%s]",
func, inputType);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
