himanshug commented on issue #9351: Adding CredentialsProvider, deprecating PasswordProvider URL: https://github.com/apache/druid/issues/9351#issuecomment-586348888 > Hmm, should one CredentialsProvider be able to handle multiple secrets? Would you tell me some examples? For example, https://github.com/apache/druid/blob/master/extensions-core/simple-client-sslcontext/src/main/java/org/apache/druid/https/SSLClientConfig.java has three secrets which could be logically related Also, now that I remember, even the interface `String getPassword(String key);` would have problems, only way to prevent the problem mentioned in #7400 would be to have an interface like below ( as suggested in https://github.com/apache/druid/issues/6666#issuecomment-486398615 ) ``` interface CredentialsProvider { Map<String, String> getCredentials(); } ``` as you wanna get a snapshot of secrets in single call , if the code needs to make two/multiple calls to `CredentialsProvider` then you would continue to have the race mentioned in #7400 hopefully it made sense or I need to be more descriptive :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
