jihoonson commented on a change in pull request #9353: Inject things instead of
subclassing everything for parallel task testing
URL: https://github.com/apache/druid/pull/9353#discussion_r379883008
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseParallelIndexingTest.java
##########
@@ -197,62 +182,52 @@ private void testRunAndOverwrite(@Nullable Interval
inputInterval, Granularity s
}
@Test
- public void testWithoutInterval() throws Exception
+ public void testWithoutInterval()
{
testRunAndOverwrite(null, Granularities.DAY);
}
@Test()
- public void testRunInParallel() throws Exception
+ public void testRunInParallel()
{
// Ingest all data.
- testRunAndOverwrite(Intervals.of("2017/2018"), Granularities.DAY);
+ testRunAndOverwrite(Intervals.of("2017-12/P1M"), Granularities.DAY);
Review comment:
Hmm, since the test data is generated in each class, I think it's better to
have the constant separately in each class as well. Added constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
