jihoonson commented on a change in pull request #6974: sql support for dynamic 
parameters
URL: https://github.com/apache/druid/pull/6974#discussion_r380984221
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java
 ##########
 @@ -131,12 +140,29 @@ private String sqlQueryId()
     return (String) this.queryContext.get(PlannerContext.CTX_SQL_QUERY_ID);
   }
 
+  public void setParameters(List<TypedValue> parameters)
+  {
+    this.parameters = parameters;
+  }
+
+  public PrepareResult prepare(AuthenticationResult authenticationResult) 
throws ValidationException, RelConversionException, SqlParseException
 
 Review comment:
   nit: please break the line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to