QiuMM commented on a change in pull request #9372: Add config option for 
namespacePrefix
URL: https://github.com/apache/druid/pull/9372#discussion_r381826855
 
 

 ##########
 File path: 
extensions-contrib/opentsdb-emitter/src/test/java/org/apache/druid/emitter/opentsdb/OpentsdbEmitterConfigTest.java
 ##########
 @@ -39,10 +39,41 @@ public void setUp()
   @Test
   public void testSerDeserOpentsdbEmitterConfig() throws Exception
   {
-    OpentsdbEmitterConfig opentsdbEmitterConfig = new 
OpentsdbEmitterConfig("localhost", 9999, 2000, 2000, 200, 2000, 10000L, null);
+    OpentsdbEmitterConfig opentsdbEmitterConfig = new 
OpentsdbEmitterConfig("localhost", 9999, 2000, 2000, 200, 2000, 10000L, null, 
"druid");
     String opentsdbEmitterConfigString = 
mapper.writeValueAsString(opentsdbEmitterConfig);
     OpentsdbEmitterConfig expectedOpentsdbEmitterConfig = 
mapper.readerFor(OpentsdbEmitterConfig.class)
                                                                 
.readValue(opentsdbEmitterConfigString);
     Assert.assertEquals(expectedOpentsdbEmitterConfig, opentsdbEmitterConfig);
   }
+
+  @Test
+  public void testSerDeserOpentsdbEmitterConfigWithSpaceNamespace() throws 
Exception
 
 Review comment:
   nit: rename `testSerDeserOpentsdbEmitterConfigWithSpaceNamespace` to 
`testSerDeserOpentsdbEmitterConfigWithNamespaceContainingSpace`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to