gianm commented on a change in pull request #9163: Improved the readability and
fixed few java warnings
URL: https://github.com/apache/druid/pull/9163#discussion_r382836818
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidConvention.java
##########
@@ -73,7 +73,7 @@ public RelTraitDef getTraitDef()
@Override
public boolean satisfies(RelTrait trait)
{
- return trait == this;
+ return trait.equals(this);
Review comment:
It's ok, IMO, and removes any question about whether `==` and `equals` are
compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
