jnaous commented on a change in pull request #9360: Create splits of multiple
files for parallel indexing
URL: https://github.com/apache/druid/pull/9360#discussion_r382950480
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/firehose/WindowedSegmentId.java
##########
@@ -56,6 +63,35 @@ public String getSegmentId()
@JsonProperty
public List<Interval> getIntervals()
{
- return intervals;
+ return Collections.unmodifiableList(intervals);
+ }
+
+ @Override
+ public boolean equals(Object o)
+ {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ WindowedSegmentId segmentId1 = (WindowedSegmentId) o;
+ return Objects.equals(segmentId, segmentId1.segmentId) &&
+ Objects.equals(intervals, segmentId1.intervals);
+ }
+
+ @Override
+ public int hashCode()
+ {
+ return Objects.hash(segmentId, intervals);
+ }
Review comment:
tests for equals and hashcode please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
