gianm commented on a change in pull request #9122: Add SQL GROUPING SETS
support.
URL: https://github.com/apache/druid/pull/9122#discussion_r384086213
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -369,13 +374,13 @@ public boolean doMergeResults(final GroupByQuery query)
.map(AggregatorFactory::getCombiningFactory)
.collect(Collectors.toList())
)
- .withSubtotalsSpec(null)
- .withDimFilter(null);
-
+ .withVirtualColumns(VirtualColumns.EMPTY)
+ .withDimFilter(null)
+ .withSubtotalsSpec(null);
Review comment:
What do you mean by 'make sense'? It makes sense to me in that you have an
immutable object (the GroupByQuery) and you are using chaining to create a
derived copy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
