suneet-s commented on a change in pull request #9122: Add SQL GROUPING SETS
support.
URL: https://github.com/apache/druid/pull/9122#discussion_r384129305
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -369,13 +374,13 @@ public boolean doMergeResults(final GroupByQuery query)
.map(AggregatorFactory::getCombiningFactory)
.collect(Collectors.toList())
)
- .withSubtotalsSpec(null)
- .withDimFilter(null);
-
+ .withVirtualColumns(VirtualColumns.EMPTY)
+ .withDimFilter(null)
+ .withSubtotalsSpec(null);
Review comment:
Sorry, I should have phrased that better.
I meant that there seems to be a lot of overlap between the `.with...`
functions and the `GroupByQuery.Builder` functions. When I saw that pattern, I
was wondering how do you choose between the 2. And since both exist, I may not
pick the correct one.
Nothing to change here - just my stream of thought while reading the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
