ccaominh commented on a change in pull request #9122: Add SQL GROUPING SETS
support.
URL: https://github.com/apache/druid/pull/9122#discussion_r384190521
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/Grouping.java
##########
@@ -92,19 +104,25 @@ private Grouping(
public static Grouping create(
final List<DimensionExpression> dimensions,
+ final Subtotals subtotals,
final List<Aggregation> aggregations,
final DimFilter havingFilter,
final RowSignature outputRowSignature
)
{
- return new Grouping(dimensions, aggregations, havingFilter,
outputRowSignature);
+ return new Grouping(dimensions, subtotals, aggregations, havingFilter,
outputRowSignature);
Review comment:
Should `havingFilter` be annotated with `@Nullable` for this method as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
