abossert opened a new pull request #9428: Adding request logging support to the Kafka-Emitter extension URL: https://github.com/apache/druid/pull/9428 This is an effort to revive #6493 , which seemed to have fizzled out some time ago. I managed to miss #6493 during my initial work...I had created a very similar implementation that I have been using locally that simply changed the `toMap()` method of `DefaultRequestLogEvent` to output a map of the event properties, rather than an empty map. I have attempted to address the concerns that @gianm raised in his review of #6493 in that I removed the `request.topic` as a mandatory field and I also implemented the simpler code that @gianm suggested in the `org.apache.druid.emitter.kafka.KafkaEmitter` class. This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [x] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `org.apache.druid.emitter.kafka.KafkaEmitterConfigTest` * `org.apache.druid.emitter.kafka.KafkaEmitterConfig` * `org.apache.druid.emitter.kafka.KafkaEmitter` * `org.apache.druid.emitter.kafka.KafkaEmitter`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
