gianm commented on issue #9484: Harmonization and bug-fixing for selector and 
filter behavior on unknown types.
URL: https://github.com/apache/druid/pull/9484#issuecomment-597108855
 
 
   > Tagged release notes because this PR changes the behavior of complex 
metric aggregation at ingestion time when SQL compatible null handling is 
_disabled_ (the default mode) to now aggregate the default 0 values for rows 
instead of skipping them. This change is for the better imo since it makes 
things symmetrical to as if you ingested the raw data and built the sketch at 
query time, but it is different so worth calling out, and you can see the 
effects in some of the test changes in this PR.
   
   Thanks for pointing that out. Yes, I agree, it is for the better since it 
makes the ingest-time behavior and query-time behavior the same. This is part 
of the promise of Druid rollup in the first place (you can move aggregations to 
ingest time if you want).
   
   Btw, this patch also ends up making ingest-time transforms and filters 
behave more consistently with query-time ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to