himanshug commented on a change in pull request #9350: Overlord to support
autoscalers per indexer/middlemanager category
URL: https://github.com/apache/druid/pull/9350#discussion_r387845217
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/setup/WorkerSelectUtils.java
##########
@@ -108,8 +112,39 @@ public static ImmutableWorkerInfo selectWorker(
final Function<ImmutableMap<String, ImmutableWorkerInfo>,
ImmutableWorkerInfo> workerSelector
)
{
- final Map<String, ImmutableWorkerInfo> runnableWorkers =
getRunnableWorkers(task, allWorkers, workerTaskRunnerConfig);
+ final Map<String, ImmutableWorkerInfo> runnableWorkers =
getRunnableWorkers(
+ task,
+ allWorkers,
+ workerTaskRunnerConfig
+ );
+
+ // select worker according to worker category spec
+ if (workerCategorySpec != null) {
Review comment:
this check is again done in getTaskCategory(..) and is redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
