maytasm3 commented on a change in pull request #9492: add manual laning
strategy, integration test
URL: https://github.com/apache/druid/pull/9492#discussion_r391217720
##########
File path:
integration-tests/src/test/java/org/apache/druid/tests/query/ITWikipediaQueryTest.java
##########
@@ -51,15 +69,78 @@ public void before() throws Exception
ITRetryUtil.retryUntilTrue(
() -> coordinatorClient.areSegmentsLoaded(WIKIPEDIA_DATA_SOURCE),
"wikipedia segment load"
);
- coordinatorClient.initializeLookups(WIKIPEDIA_LOOKUP_RESOURCE);
- ITRetryUtil.retryUntilTrue(
- () -> coordinatorClient.areLookupsLoaded(WIKI_LOOKUP), "wikipedia
lookup load"
- );
+ if (!coordinatorClient.areLookupsLoaded(WIKI_LOOKUP)) {
+ coordinatorClient.initializeLookups(WIKIPEDIA_LOOKUP_RESOURCE);
+ ITRetryUtil.retryUntilTrue(
+ () -> coordinatorClient.areLookupsLoaded(WIKI_LOOKUP), "wikipedia
lookup load"
+ );
+ }
}
@Test
public void testWikipediaQueriesFromFile() throws Exception
{
queryHelper.testQueriesFromFile(WIKIPEDIA_QUERIES_RESOURCE, 2);
}
+
+ @Test
Review comment:
Should we only have a test for when the Manual Lane From Context That Arent
In Map is given? For example, if lane in query context is "some-unknown-lane"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
