jihoonson commented on a change in pull request #9492: add manual laning 
strategy, integration test
URL: https://github.com/apache/druid/pull/9492#discussion_r391885566
 
 

 ##########
 File path: docs/configuration/index.md
 ##########
 @@ -1505,7 +1505,16 @@ This strategy can be enabled by setting 
`druid.query.scheduler.laning.strategy=h
 
 |Property|Description|Default|
 |--------|-----------|-------|
-|`druid.query.scheduler.laning.maxLowPercent`|Maximum percent of the smaller 
number of`druid.server.http.numThreads` or `druid.query.scheduler.numThreads`, 
defining the number of HTTP threads that can be used by queries with a priority 
lower than 0. Value must be in the range 1 to 100, and will be rounded up|No 
default, must be set if using this mode|
+|`druid.query.scheduler.laning.maxLowPercent`|Maximum percent of the smaller 
number of `druid.server.http.numThreads` or `druid.query.scheduler.numThreads`, 
defining the number of HTTP threads that can be used by queries with a priority 
lower than 0. Value must be in the range 1 to 100, and will be rounded up|No 
default, must be set if using this mode|
+
+
+###### 'Manual' laning strategy
+This laning strategy is best suited for cases where one or more external 
applications which query Druid are capable of manually deciding what lane a 
given query should belong to. Configured with a map of lane names to percent or 
exact max capacities, queries with a matching `lane` parameter in the [query 
context](../querying/query-context.md) will be subjected to those limits.
+
+|Property|Description|Default|
+|--------|-----------|-------|
+|`druid.query.scheduler.laning.lanes.{name}`|Maximum percent or exact limit of 
queries that can concurrently run in the defined lanes. Any number of lanes may 
be defined like this.|No default, must define at least one lane with a limit 
above 0. If `druid.query.scheduler.laning.isLimitPercent` is set to `true`, 
numbers must be in the range of 1 to 100.|
 
 Review comment:
   > numbers must be in the range of 1 to 100.
   
   Should it say the number type is the integer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to