ccaominh commented on a change in pull request #9516: More efficient join
filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393402217
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
##########
@@ -237,22 +218,16 @@ public Metadata getMetadata()
@Nullable final QueryMetrics<?> queryMetrics
)
{
-
final List<VirtualColumn> preJoinVirtualColumns = new ArrayList<>();
final List<VirtualColumn> postJoinVirtualColumns = new ArrayList<>();
+
final Set<String> baseColumns =
determineBaseColumnsWithPreAndPostJoinVirtualColumns(
Review comment:
With the deletion below, CI (spotbugs and intellij inspections) is flagging
this as unused now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
